Amount input #91
Merged
Amount input #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
reviewed
Mar 6, 2024
0xpatrickdev
approved these changes
Mar 6, 2024
0xpatrickdev
reviewed
Mar 6, 2024
| const parsed = parseAsValue(str, AssetKind.NAT, decimalPlaces); | ||
| onChange(parsed); | ||
| } catch { | ||
| console.debug('Invalid input', str); |
There was a problem hiding this comment.
Maybe add an optional onError prop?
There was a problem hiding this comment.
I don't think this is worth bubbling up necessarily. I'm not sure in practice when parseAsValue would throw (because we're giving it a NAT here and a string), it's more just so the app doesn't crash worst case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Agoric/agoric-sdk#8893
useAmountInputhook based off the implementation in dapp-inter for handling denom decimal places.<AmountInput>component that makes use of the hook conveniently.Tested locally with dapp-offer-up