Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary folders like test or tools are included while installing edge-js . #200

Closed
PranithaSai opened this issue Apr 29, 2024 · 4 comments

Comments

@PranithaSai
Copy link

Steps to reproduce:

  • Create a node-js project
  • run npm install edge-js command
  • folders like edge-js/test are included
    Are they really necessary?
@agracio
Copy link
Owner

agracio commented Apr 29, 2024

Good point except for tools since install.js and associated scripts are located there.
There is also stress, performance and samples. Will exclude them for next release.

@PranithaSai
Copy link
Author

PranithaSai commented May 2, 2024

Good point except for tools since install.js and associated scripts are located there. There is also stress, performance and samples. Will exclude them for next release.

can we also exclude src locally (from node_modules/edge-js/src) if we only need the part of code that allows the .NET and node-js integration to work ( if we are installing the edge-js as dependancy )?

@agracio
Copy link
Owner

agracio commented May 2, 2024

'src' is required for installing edge-js using npm i edge-js. While only parts of it are required on Windows both Linux and macOS require full source as it is rebuilt on npm i edge-js rather than using pre-built libraries that are under lib/native.

EDIT: locally you can exclude node_modules/edge-js/src, it is only required for npm i edge-js.

@agracio
Copy link
Owner

agracio commented May 3, 2024

New version released. Removed all unnecessary files from package.

@agracio agracio closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants