Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Elm version 0.17 #13

Closed
Kyarigwo opened this issue May 21, 2016 · 1 comment
Closed

Update for Elm version 0.17 #13

Kyarigwo opened this issue May 21, 2016 · 1 comment

Comments

@Kyarigwo
Copy link

I have updated my pull request for updating to Elm version 0.17. The changes that I have made are:

Add a new module, Elm.Versions exporting a type
data ElmVersion
= Elm0p16
| Elm0p17

Modify Elm.Module, adding a function
MakeElmModuleWithVersion which takes an ElmVersion as it's first parameter, hence switching on version, and modified the existing makeElmModule to be makeElmModuleWithVersion Elm0p16, so that existing code should run without any changes.

Finally, I have added two tests to ModuleSpec, one to test makeElmModuleWithVersion for Elm0p16 and one for Elm0p17.

Please suggest any changes.

@agrafix
Copy link
Owner

agrafix commented Jun 20, 2016

Merged in #12

@agrafix agrafix closed this as completed Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants