Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tools #33

Closed
stdavis opened this issue Oct 6, 2020 · 3 comments
Closed

Build Tools #33

stdavis opened this issue Oct 6, 2020 · 3 comments

Comments

@stdavis
Copy link
Member

stdavis commented Oct 6, 2020

Should we be using webpack to build our distributable code that gets published to npm?

I get the following error when running jest tests in a project that uses sherlock (via npm i @agrc/sherlock):
image

I don't get this error when running the application itself. I assume that it's because Jest is missing regenerator-runtime. In fact, when I add import 'regenerator-runtime'; to the jest setup file, everything works as expected.

I wonder if there's a way to make our packages work without any special config. I started looking through shared component tutorials and most of them use webpack. Maybe we can use webpack to make a more generic output. Or maybe we just need to add some sort of config to babel? Or maybe, this isn't a big deal. :)

@steveoh
Copy link
Member

steveoh commented Oct 6, 2020

Let's chat about this in slack and post an update here

@stdavis
Copy link
Member Author

stdavis commented Oct 30, 2020

I'm still not sure that we are building our components appropriately because of stuff like this: c76cedb (#235)

@stdavis
Copy link
Member Author

stdavis commented Jun 23, 2022

We are going to use Vite to build to esm and umd.

@stdavis stdavis closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants