Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation problems #337

Closed
fluca1978 opened this issue Dec 14, 2022 · 0 comments
Closed

Fix compilation problems #337

fluca1978 opened this issue Dec 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@fluca1978
Copy link
Collaborator

Current head has problems when compiling with gcc 12 and -W error option, as reported in comment #336 (comment) .
@fluca1978 fluca1978 added the bug Something isn't working label Dec 14, 2022
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Dec 14, 2022
@fluca1978
[agroal#337] Fix compilation problems
a1b364a 
As reported in CI test failures
<agroal#336 (comment)>
and
<agroal#336 (comment)>
the system does not compile under GCC 12 with `-Werror` option.

This commit fixes the string length problem reported by gcc.

Close agroal#337
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Dec 14, 2022
@fluca1978
[agroal#337] Fix compilation problems
8ae6072 
As reported in CI test failures
<agroal#336 (comment)>
and
<agroal#336 (comment)>
the system does not compile under GCC 12 with `-Werror` option.

This commit fixes the string length problem reported by gcc.

Close agroal#337
@brettgoss brettgoss mentioned this issue Dec 14, 2022
Closed
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Dec 15, 2022
@fluca1978
[agroal#337] Fix compilation problems
a0311d6 
As reported in CI test failures
<agroal#336 (comment)>
and
<agroal#336 (comment)>
the system does not compile under GCC 12 with `-Werror` option.

This commit fixes the string length problem reported by gcc.
The `to_string` internal method used to get a stringify value
of a configuration parameter has changed so that now accepts a buffer
size. Such size indicates the max length of the destinatiojn buffer
and allows the function to do some more checks about what to copy onto
the buffer.

Close agroal#337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fluca1978