Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid "restart required" for pid file when not needed #340

Closed
fluca1978 opened this issue Dec 15, 2022 · 0 comments · Fixed by #342
Closed

Avoid "restart required" for pid file when not needed #340

fluca1978 opened this issue Dec 15, 2022 · 0 comments · Fixed by #342
Labels
bug Something isn't working

Comments

@fluca1978
Copy link
Collaborator

The init file is automatically initialized thru a pgagroal_init_pid_file_if_needed function.
So far so good, but:

$ pgagroal-cli reload

issues

INFO  configuration.c:2736 Restart required for pidfile - Existing /tmp/pgagroal.5432.pid New

This is wrong, the pid file has not changed, simply it was not found on the new configuration that is going to be reloaded.
The init file change must be detected correctly, therefore the restart_string must be able to understand if a parameter not set represents a change or not.
@fluca1978 fluca1978 added the bug Something isn't working label Dec 15, 2022
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Dec 15, 2022
@fluca1978
[agroal#340] Remove useless restart required messages.
3ba2dcb 
When the configuration reloads, it does not make any sense
to issue a warning about variables, most notably the pid file, that
are set to a default when the application runs and no configuration
has been provided.

Close agroal#340
@fluca1978 fluca1978 mentioned this issue Dec 15, 2022
Merged
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Dec 15, 2022
@fluca1978
[agroal#340] Remove useless restart required messages.
99d5a07 
When the configuration reloads, it does not make any sense
to issue a warning about variables, most notably the pid file, that
are set to a default when the application runs and no configuration
has been provided.

Close agroal#340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#340] Remove useless restart required messages. fluca1978/pgagroal
1 participant
@fluca1978