Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using aiofiles for async file IO #266

Closed
Tinche opened this issue Apr 23, 2021 · 3 comments
Closed

Using aiofiles for async file IO #266

Tinche opened this issue Apr 23, 2021 · 3 comments

Comments

@Tinche
Copy link

Tinche commented Apr 23, 2021

Hello,

I have a PR open against my aiofiles library adding anyio support (by a third party): Tinche/aiofiles#97

However I see that anyio already has support for async file IO. Would you be interested in dropping your code and depending on aiofiles if this is merged?

If not, I don't really see the point of merging it in, since the logic is already implemented here.

@agronholm
Copy link
Owner

agronholm commented Apr 23, 2021

Async file I/O is a core part of AnyIO functionality. I have no intention of dropping it, as it would add a dependency with no benefits. To be frank, there is little aiofiles can offer over AnyIO, but if you merge that PR, it gains trio support, and support for any future anyio backend (twisted?).

@Tinche
Copy link
Author

Tinche commented Apr 23, 2021

Okie dokie!

@Tinche Tinche closed this as completed Apr 23, 2021
@Tinche
Copy link
Author

Tinche commented Apr 23, 2021

Forgot to add, thank you for your insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants