Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0-alpha.1 – forEach Implementation #4

Merged
merged 5 commits into from
Jul 23, 2018

Conversation

ipotro
Copy link
Owner

@ipotro ipotro commented Jul 23, 2018

This PR implements the forEach function, also it prepares the release using Webpack and Universal Module Definition.


Issues Addressed

All issues in milestone: [2] High Order Functions

Release Checklist

  • [bd5925f]forEach: Add source code and basic tests.
  • [6613128]docs: Add code documentation to forEach function.
  • [23276ab]docs: Add two more code comments to forEach implementation.
  • [7d37355]tool: Add webpack configuration to build the library.
  • [2e96f28]tool: Add libraryExport option in webpack config.

Approvals

  • Final approval @agzeri

Copy link
Owner Author

@ipotro ipotro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description

Looks really great to me.


Review Checklist

  • Well documented code using standard practices.
  • Great tests using the testing suite.
  • Nice webpack configuration.
  • Cool way to handle the build process with npm.

Kudos for preparing the release with UMD and webpack.


Approved by @agzeri.

@ipotro ipotro merged commit 362baf7 into develop Jul 23, 2018
@ipotro ipotro mentioned this pull request Jul 23, 2018
5 tasks
@ipotro ipotro deleted the 1.0.0/forEachImplementation branch July 23, 2018 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant