Configure highlight color for current context & namespace #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetb
requested changes
Jun 5, 2018
README.md
Outdated
|
|
||
| To change background colour to White for highlighting current context: | ||
|
|
||
| `export KUBECTX_CURRENT_FGCOLOR=$(tput setaf 7)` |
README.md
Outdated
| @@ -73,6 +73,21 @@ Active namespace is "default". | |||
|
|
|||
| ----- | |||
|
|
|||
| ### Highlight Current Context | |||
| By default, current context is highlighted by yellow foreground & black background | |||
There was a problem hiding this comment.
no need to include the defaults here. delete this sentence
README.md
Outdated
| ### Highlight Current Context | ||
| By default, current context is highlighted by yellow foreground & black background | ||
|
|
||
| It is configurable by setting environment variables `KUBECTX_CURRENT_FGCOLOR` & `KUBECTX_CURRENT_BGCOLOR` |
There was a problem hiding this comment.
we need to shorten this section. consider the following rewrite.
Customizing current context colors
If you like to customize the colors indicating the current namespace or context, set the environment variables
KUBECTX_CURRENT_FGCOLORandKUBECTX_CURRENT_BGCOLOR:
export KUBECTX_CURRENT_FGCOLOR=$(tput setaf 6) # blue text export KUBECTX_CURRENT_FGCOLOR=$(tput setaf 7) # white backgroundRefer color codes here.
README.md
Outdated
| @@ -73,6 +73,21 @@ Active namespace is "default". | |||
|
|
|||
| ----- | |||
|
|
|||
| ### Highlight Current Context | |||
There was a problem hiding this comment.
move this after "## Installation" and call it the title I described below.
Closed
|
@prabhu43 Thanks for the PR. I only requested a few docs changes, when you have time please take a look. |
|
@ahmetb I updated the doc with your inputs. |
ahmetb
approved these changes
Jun 7, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.