Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #121, Issue #140 #198

Closed
wants to merge 1 commit into from
Closed

Issue #121, Issue #140 #198

wants to merge 1 commit into from

Conversation

Josephblt
Copy link
Contributor

Min Max Constraints Support - Issue #121
Round Corners Support - Issue #140. This fixes only part of the problem.

@Josephblt
Min Max Constraints Support - Issue #121
8904f57 
Round Corners Support - Issue #140
@Josephblt Josephblt changed the title Issue #121, Issue #140, Issue #121, Issue #140 Oct 20, 2017
@romartin
Copy link
Contributor

Hey @Josephblt
Thanks for this, anyway still missing 2 things:

  • Please change the commit message to reference the right ticket number (I think 121 is not the right one..). So just updating the commit message and force pushing again is fine.

  • While dragging the resize CP, the shape size is being "constrained", that's working fine, but the concrete CP that is being drag, is still being located as the drag mouse location... I would expect forcing the location for the concrete CP as well, once it gets to its min/max, WDYT?

See issue:
resize-constraints-issue

We're actually doing the same for shape docking - once a shape is being docked, while dragging it, it's located at the dock location although you keep moving the mouse ...

romartin
romartin suggested changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@romartin romartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes. See message above.

@Josephblt
Copy link
Contributor Author

Josephblt commented Oct 23, 2017 via email

@romartin
Copy link
Contributor

@Josephblt I think the best option is just setting a drag constraint enforcer for each of the resize CPs, and apply the right adjust once getting to the min/max values, if makes sense.

@Josephblt Josephblt closed this Oct 25, 2017
@Josephblt Josephblt deleted the issues121-140 branch October 25, 2017 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romartin romartin romartin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josephblt @romartin