JBPM-6338: [Lienzo] Text wrapping: Pluggable line splitter #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Christopher-Chianelli FYI and comment. |
jomarko
approved these changes
Aug 30, 2017
There was a problem hiding this comment.
Very nice coverage @manstis ! please just see my two comments in the PR dikalo/lienzo-core#187 with real changes.
|
@SprocketNYC Thanks for merging dikalo/lienzo-core#187 This PR contains tests for that what you have merged and should probably accompany it. |
romartin
approved these changes
Sep 20, 2017
|
NOTE This PR depends on |
|
Rebased and merged: a44c612 |
romartin
pushed a commit
to romartin/lienzo-tests
that referenced
this pull request
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See See https://issues.jboss.org/browse/JBPM-6338
This is the accompanying tests.