Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrefetchWorkerExecutorService的关闭钩子（ShutdownHook）可能需要使用者关闭 #16

Closed
cubita-io opened this issue Jan 14, 2022 · 8 comments
Closed

PrefetchWorkerExecutorService的关闭钩子（ShutdownHook）可能需要使用者关闭 #16

cubita-io opened this issue Jan 14, 2022 · 8 comments
Assignees
@cubita-io
Labels
enhancement New feature or request

Comments

@cubita-io
Copy link
Contributor

cubita-io commented Jan 14, 2022 •
edited
Loading

image

如果Distributor类型为JDBC或者其他，这个自动关闭钩子，如果运行在数据库关闭之后，那边会引起访问数据库，建议让使用者来决定是否由cosid关闭；增加一个是否自动关闭的属性或者构造函数设置，使用者可以设置
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Jan 14, 2022
@Ahoo-Wang
Copy link
Owner

agree.

@cubita-io
Copy link
Contributor Author

pull

@Ahoo-Wang
Copy link
Owner

nice! merged.

@Ahoo-Wang Ahoo-Wang reopened this Jan 14, 2022
@Ahoo-Wang
Copy link
Owner

@cubita-io 还有 spring-boot-starter 自定义配置部分的内容需要完成。

CosId/cosid-spring-boot-starter/src/main/java/me/ahoo/cosid/spring/boot/starter/segment/CosIdSegmentAutoConfiguration.java

Line 64 in 831eeb4

return new PrefetchWorkerExecutorService(prefetchWorker.getPrefetchPeriod(), prefetchWorker.getCorePoolSize());

@cubita-io
Copy link
Contributor Author

#18
#19

@Ahoo-Wang
Copy link
Owner

Ahoo-Wang commented Jan 14, 2022 •
edited
Loading

你可以把俩个PR （#18 #19 ）合并到一起提交吗

@cubita-io
Copy link
Contributor Author

cubita-io commented Jan 14, 2022 •
edited
Loading

#18
#19
麻烦把这两个都关闭了吧

@Ahoo-Wang
Copy link
Owner

Ahoo-Wang commented Jan 14, 2022 •
edited
Loading

nice , #20 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cubita-io cubita-io

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ahoo-Wang @cubita-io