Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize hook naming convention #18

Closed
ahw opened this issue Sep 21, 2014 · 1 comment
Closed

Generalize hook naming convention #18

ahw opened this issue Sep 21, 2014 · 1 comment

Comments

@ahw
Copy link
Owner

ahw commented Sep 21, 2014

It's weird that the patterns are [SORT].[EVENT].[EXT].vimhook, [SORT].[EVENT].vimhook and [FILENAME].vimhook. A better pattern might be ^\.?(\d+\.)?(.+\.)?(\w+)\.vimhook which is best visualized on Regexper. Basically it allows an optional sort key, an optional "suffix" (which could be just "js" or the whole filename itself), and the event name. They each have a "." dot between them and it allows for an optional dot at the beginning, which lets the user decide whether or not to make the file hidden.

@ahw ahw changed the title Allow sort keys for file-specific hook scripts Generalize hook naming convention Jan 4, 2015
@ahw
Copy link
Owner Author

ahw commented Jan 8, 2015

Finished in ad8870e. Was able to remove a lot of code.

@ahw ahw closed this as completed Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant