Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a description key. #39

Closed
oliviertassinari opened this issue Jan 12, 2018 · 6 comments
Closed

Support a description key. #39

oliviertassinari opened this issue Jan 12, 2018 · 6 comments

Comments

@oliviertassinari
Copy link
Contributor

The .size-limit file on Material-UI side is growing. I have started adding description information so external contributors can better understand why their build is failing.

capture d ecran 2018-01-12 a 22 29 52

This is a suggestion, I'm not 100% convinced it's a good idea. Here it is.
What do you think of displaying the description in the output of the CLI?
@ai
Copy link
Owner

ai commented Jan 13, 2018

So, you want The main bundle of the documentation instead of .next/app.js? I think it is a great idea! 👍

I will try to implement it tomorrow.

@oliviertassinari
Copy link
Contributor Author

@ai I'm happy you like my proposition :).

@ai
Copy link
Owner

ai commented Jan 14, 2018

Done 360735a

I used name instead of description since it is shorter and more clear.

@ai ai closed this as completed Jan 14, 2018
@oliviertassinari
Copy link
Contributor Author

@ai Thanks, I'm updating our .size-limit :).

@ai
Copy link
Owner

ai commented Jan 14, 2018

I will release it 30 minutes later

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this issue Jan 14, 2018
@oliviertassinari
[core] Misc effort
38f797d 
- Take ai/size-limit#39 into account.
- Take Matt spacing feedback mui#9863 (comment)
- Fix some W3C warnings mui#9867
@oliviertassinari oliviertassinari mentioned this issue Jan 14, 2018
Merged
@ai
Copy link
Owner

ai commented Jan 14, 2018

Released in 0.14.

oliviertassinari added a commit to mui/material-ui that referenced this issue Jan 14, 2018
@oliviertassinari
[core] Misc effort (#9869)
cde8ff6 
- Take ai/size-limit#39 into account.
- Take Matt spacing feedback #9863 (comment)
- Fix some W3C warnings #9867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ai @oliviertassinari