-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix W3C validation issues #9867
Comments
Wow, that's quite some list! 😳 We'd be grateful if you were to submit a PR (many PRs?! 😅 ) for the low-hanging fruit. |
@mbrookes I will surely try to submit some PRs to fix the errors of validation. Warnings may be ignored for now. |
It might require some fixes in Next.js side.
It will help with Material-UI credibility. |
- Take ai/size-limit#39 into account. - Take Matt spacing feedback mui#9863 (comment) - Fix some W3C warnings mui#9867
- Take ai/size-limit#39 into account. - Take Matt spacing feedback #9863 (comment) - Fix some W3C warnings #9867
I have been fixing some of the issues. I'm more or less stuck with the homepage. Ideally, I would also scan all the pages. |
@oliviertassinari Your changes have taken care of many errors. I have submitted a small change now as well. If you fix the duplicate ids issue and the BTW, thank you for the quick turnaround time for fixing most of the issues. |
@sambhav-gore I'm wondering if we shouldn't close the issue now. I believe the last issues are Next.js relative. |
@oliviertassinari I still see some issues, I will list it all down here in a comment and then you can take a call about whether this can be closed. |
Following are the issues which IMO are related to the core styles of components. I am listing here the demo page name (under components demo) and the issue reported by w3c and my reasoning of it
Finally, As long as users can generate valid markup by using components slightly differently tahn in demo it is okay. My main concern is when an error is generated from core styles. |
@sambhav-gore Wow, thanks for the detailed list!
We can split the work then. I will focus on the documentation issues :). |
Can you confirm about the CircularProgress listed above in the list ? It is a percentage value ? |
It should be |
@oliviertassinari I have created a PR to fix all of the issues from the list above except for the first one - Please let me know if my changes cause any issues as I am still quite new to material-ui |
@oliviertassinari after digging a lot more I found the root cause of 1st point in my list the appearance: textfield error. It seems that the JSS generated on SSR is different than that of in-browser: SSR.jss220 {
appearance: textfield;
} In-Browser.jss273 {
-webkit-appearance: textfield;
} The SSR one is wrong since spec doesn't have |
On second thoughts, following can be changed to have vendor prefixes for webkit and moz since |
JSS doesn't vendor prefix on the server. It's up to the users, at least, it's what @kof is suggesting. I haven't tried yet. |
As of right now, yes, we should change this though. |
I'm working on it. |
I'm working on it. |
I'm working on the last appearance issue. |
@sambhav-gore We should be good now. Feel free to report and fix the w3c issues that we have missed :). Thanks a lot for raising the concern. It's important for the vision of the project that goes beyond Material Design. |
IMO and a suggestion, fixing w3c issues using |
Expected Behavior
When using material-ui with Server Side Rendering -
There should be no validation issues shown by https://validator.w3.org
Current Behavior
There are many validation issues thrown by https://validator.w3.org when using Material-UI with server side rendering
Steps to Reproduce (for bugs)
Context
I want to create an application which validates with W3C validator.
Your Environment
The text was updated successfully, but these errors were encountered: