-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI for micropipenv #27
Comments
I maintain this container image ready with all dependencies micropipenv needs for testing and I know how to configure it in Travis. So, if the Travis is a way to go, I can prepare something. I don't know much about Centos CI. Recently, @encukou has prepared tox github action with mentioned container so we might try that as well. But I have zero experience with GH actions. |
we can extend the pipeline to run the tox test with the container image for micropipenv. I will include a sample to the existing pipeline, and we can check the compatibility with it. @fridex |
What pipeline do you mean? |
I've tried three possibilities here:
|
we developed aicoe-ci based on openshift-pipeline/tekton-pipeline, it runs checks as task(similar to a job). Earlier as i stated we can embed another task for tox test, based upon the container image earlier mentioned in the thread. |
So, which one we want to use? |
Travis with Fedora container implemented in thoth-station/micropipenv#87 This issue can be closed. |
Let's close this, micropipenv is tested with Travis CI now. If there is a plan to add support for Thoth CI, we can still do it besides Travis as discussed on the call. Thanks @frenzymadness @harshad16 👍 |
Ack, tox test is already included in the pipeline. However, it needs to be refined more, it would run in parallel with the Travis test. It wouldn't cause any issue in the pull request. |
Is your feature request related to a problem? Please describe.
It would be great if we could automate testing of micropipenv for each PR. As micropipenv is on a different layer, it might be tricky to run the CI with the same configuration as for the other components of Thoth.
Describe the solution you'd like
Execute micropipenv testsuite using
tox
. We also need Python interpreters in different versions to verify the correctness. See thoth-station/micropipenv#72 for more info.Describe alternatives you've considered
As micropipenv is not tightly bound to Thoth itself, we could use centos CI or travis to execute the test suite. As the requirements are pretty straightforward we could let these solutions run the CI not to maintain big changes on our side.
The text was updated successfully, but these errors were encountered: