Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI for micropipenv #27

Closed
fridex opened this issue Jun 1, 2020 · 10 comments
Closed

Run CI for micropipenv #27

fridex opened this issue Jun 1, 2020 · 10 comments

Comments

@fridex
Copy link
Contributor

fridex commented Jun 1, 2020

Is your feature request related to a problem? Please describe.

It would be great if we could automate testing of micropipenv for each PR. As micropipenv is on a different layer, it might be tricky to run the CI with the same configuration as for the other components of Thoth.

Describe the solution you'd like

Execute micropipenv testsuite using tox. We also need Python interpreters in different versions to verify the correctness. See thoth-station/micropipenv#72 for more info.

Describe alternatives you've considered

As micropipenv is not tightly bound to Thoth itself, we could use centos CI or travis to execute the test suite. As the requirements are pretty straightforward we could let these solutions run the CI not to maintain big changes on our side.

@fridex
Copy link
Contributor Author

fridex commented Jun 1, 2020

CC @harshad16 @frenzymadness @goern

@frenzymadness
Copy link

frenzymadness commented Jun 1, 2020

I maintain this container image ready with all dependencies micropipenv needs for testing and I know how to configure it in Travis. So, if the Travis is a way to go, I can prepare something. I don't know much about Centos CI.

Recently, @encukou has prepared tox github action with mentioned container so we might try that as well. But I have zero experience with GH actions.

@harshad16
Copy link
Member

harshad16 commented Jun 1, 2020

we can extend the pipeline to run the tox test with the container image for micropipenv. I will include a sample to the existing pipeline, and we can check the compatibility with it. @fridex
and Thanks @frenzymadness for the pointing to the container image :)

@frenzymadness
Copy link

we can extend the pipeline to run the tox test with the container image for micropipenv.

What pipeline do you mean?

@frenzymadness
Copy link

I've tried three possibilities here:

  1. Pure Travis config & result — Simple configuration and the tests run on Ubuntu which should make no difference because we depends only on Python packages from PyPI.
  2. Travis with Fedora container config & result — Closer to our target environment and new Pythons are available in Fedora sooner than in Travis.
  3. GH actions with Fedora container testing PR — Looks good to me as well, has nice integration to GH but the action itself is still in pre-release (but maintained by fedora-python).

@harshad16
Copy link
Member

we can extend the pipeline to run the tox test with the container image for micropipenv.

What pipeline do you mean?

we developed aicoe-ci based on openshift-pipeline/tekton-pipeline, it runs checks as task(similar to a job). Earlier as i stated we can embed another task for tox test, based upon the container image earlier mentioned in the thread.

@frenzymadness
Copy link

So, which one we want to use?

@frenzymadness
Copy link

Travis with Fedora container implemented in thoth-station/micropipenv#87

This issue can be closed.

@fridex
Copy link
Contributor Author

fridex commented Jun 9, 2020

Let's close this, micropipenv is tested with Travis CI now. If there is a plan to add support for Thoth CI, we can still do it besides Travis as discussed on the call.

Thanks @frenzymadness @harshad16 👍

@fridex fridex closed this as completed Jun 9, 2020
@harshad16
Copy link
Member

Ack, tox test is already included in the pipeline. However, it needs to be refined more, it would run in parallel with the Travis test. It wouldn't cause any issue in the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants