Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: router doesn't support non text types #223

Closed
aidenybai opened this issue Jul 30, 2022 · 2 comments · Fixed by #233
Closed

bug: router doesn't support non text types #223

aidenybai opened this issue Jul 30, 2022 · 2 comments · Fixed by #233
Assignees
Labels
bug Something isn't working

Comments

@aidenybai
Copy link
Owner

Describe the bug
Router doesn't support non-text hrefs, and attempt to fetch and replace.

To Reproduce

<a href="/link/to/example.pdf">doesn't work</a>
@aidenybai aidenybai added the bug Something isn't working label Jul 30, 2022
@aidenybai aidenybai self-assigned this Jul 30, 2022
@staszewski
Copy link

Hey, I wanted to help. I tried to reproduce, but the example from "To Reproduce" seems to work. There is a text in href. I tried the code on top of template from https://github.com/aidenybai/million-react Can you share some context?

@aidenybai
Copy link
Owner Author

Hey @staszewski, thanks for the interest. If you look here (

.then((res) => res.text())
) any data format, when fetched, is accepted, even if it isn't text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants