Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of ConnectiveExpr easier #11

Open
aidin36 opened this issue Jan 20, 2014 · 2 comments
Open

Make use of ConnectiveExpr easier #11

aidin36 opened this issue Jan 20, 2014 · 2 comments

Comments

@aidin36
Copy link
Owner

aidin36 commented Jan 20, 2014

Right now, there's only two `create' method for ConnectiveExpr classes: one that accepts a ConnectiveExpr_, and one that accepts FieldExpr_.

But, there should be something that accepts an array or other things. So user can write:

And(Tag("..."), Tag("..."))

Create methods cannot accept an array of Expr*, because it cannot be cast to derived classes. So, we should think of a way to solve this.

One solution is to write some overloads that accepts 2, 3, or more arguments. e.g.

And::create(FiledExpr*, FieldExpr*)
@pruthig
Copy link
Contributor

pruthig commented Nov 27, 2014

Assign this one to me

@aidin36
Copy link
Owner Author

aidin36 commented Nov 27, 2014

Yours now (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants