Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow central bodies which have another primary than the Sun #184

Open
gomezzz opened this issue Jul 19, 2023 · 0 comments
Open

Allow central bodies which have another primary than the Sun #184

gomezzz opened this issue Jul 19, 2023 · 0 comments
Labels
enhancement New feature or request example An example to showcase something feature implementing a new feature help wanted Extra attention is needed physical-model All things involving some physical models

Comments

@gomezzz
Copy link
Collaborator

gomezzz commented Jul 19, 2023

Feature

Desired Behavior / Functionality

Allowing other central bodies such as the Moon.

What Needs to Be Done

Right now, we convert to heliocentric coordinates to compute eclipses using pykep.

This conversion needs to be specified in some way if the body's motion around the sun is not implicitly modelled via pykep.

Atm, the conversion to heliocentric happens in the code at

if reference_frame == ReferenceFrame.Heliocentric:

How Can It Be Tested

Create a lunar scenario ✌️

@gomezzz gomezzz added enhancement New feature or request help wanted Extra attention is needed example An example to showcase something feature implementing a new feature physical-model All things involving some physical models labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request example An example to showcase something feature implementing a new feature help wanted Extra attention is needed physical-model All things involving some physical models
Projects
None yet
Development

No branches or pull requests

1 participant