-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deepbots GoalEnv #79
Comments
@KelvinYang0320 Are you interested in taking look at gym's GoalEnv and what we need to do in order to integrate it with deepbots? |
@tsampazk Yes, I will spend some time to look into GoalEnv. |
@KelvinYang0320 Thank you! |
@ManosMagnus @tsampazk
What do you think? |
This is quite tricky i think. On the one hand, we very much prefer not to introduce any additional dependencies to the framework. Especially for a library that will be or is used by very specific use cases and not universally. On the other hand, i think that it is not proper and we shouldn't just copy the existing GoalEnv from the gym-robotics library. @KelvinYang0320 is this actually needed for the panda example? Or any other current example? |
I think GoalEnv is quite useful for our robotic tasks as I mentioned here.
Another example is that Panda-gym v2.0.1 works with
Yes, HER requires the environment to inherits from |
Alright thanks for the information!
I thought about the additional dependency on gym-robotics. Using this would mean adding additional inheritance to some gym-robotics class that includes GoalEnv. I will need some time to look into this further in detail, so i think we can put this on hold for a while and focus on the fixes regarding deepworlds. Unless you have a clear idea on what we can do specifically, so we can discuss it. |
@tsampazk I agree to put this on hold. 👌
|
Yeah i skimmed through that issue and discussion and followed a couple of links, but it started to look like a long rabbit hole of links and discussions and just stopped myself. :P That quote is a really really good summary of gym's mission, but i'm not exactly sure what that means for us, being a framework for a robotic simulator. I guess we'll see in the future. |
@tsampazk I think we can move this issue to Pre-release 0.2.1-dev0 or close it. What do you think? |
Yes @KelvinYang0320, it seems to still be an open issue, i think that we can move it to the pre-release. |
No description provided.
The text was updated successfully, but these errors were encountered: