Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level_5 module #5

Closed
DxqS opened this issue Mar 4, 2020 · 2 comments
Closed

level_5 module #5

DxqS opened this issue Mar 4, 2020 · 2 comments
Labels
bug Something isn't working PyNET PyNET model

Comments

@DxqS
Copy link

DxqS commented Mar 4, 2020

image

image

which one is right?

@Jam-G
Copy link

Jam-G commented Mar 5, 2020

@DxqS The code you shown in the second picture, is pytorch implementation of PyNET,and the tensorflow implementation of PyNET is same to the description in papers.

And I checked the pytorch implementation of PyNET , the autor @aiff22 modified the model exactly and declared three major modifications.
But he didn't mention the modifications about dropping the skip connections of level5.
If @aiff22 have tried such modifications and it has better effects? or just omitted?
It confused me too.

@aiff22 aiff22 added the PyNET PyNET model label Mar 7, 2020
@aiff22
Copy link
Owner

aiff22 commented Mar 7, 2020

Hi @DxqS, @Jam-G,

The right one is in the paper and in this repository. In the PyTorch repository, it was just omitted by mistake. You can add skip-connections in the 5th level by changing the above code to:

 def level_5(self, pool4):

        conv_l5_d1 = self.conv_l5_d1(pool4)
        conv_l5_d2 = self.conv_l5_d2(conv_l5_d1) + conv_l5_d1
        conv_l5_d3 = self.conv_l5_d3(conv_l5_d2) + conv_l5_d2
        conv_l5_d4 = self.conv_l5_d4(conv_l5_d3)

        conv_t4a = self.conv_t4a(conv_l5_d4)
        conv_t4b = self.conv_t4b(conv_l5_d4)

        conv_l5_out = self.conv_l5_out(conv_l5_d4)
        output_l5 = self.output_l5(conv_l5_out)

        return output_l5, conv_t4a, conv_t4b

@aiff22 aiff22 closed this as completed Mar 7, 2020
@aiff22 aiff22 added the bug Something isn't working label Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PyNET PyNET model
Projects
None yet
Development

No branches or pull requests

3 participants