Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BASH completion functionality #359

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Add BASH completion functionality #359

merged 1 commit into from
Feb 23, 2023

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Feb 16, 2023

As an alternative, we could install bash-completion package via APT, but using mamba-bash-completion from conda-forge makes it work for conda/mamba commands as well so I think it is preferable.

Closes #358

Tested locally (image ghcr.io/aiidalab/full-stack:pr-359)

@danielhollas danielhollas self-assigned this Feb 16, 2023
@danielhollas danielhollas added enhancement dependencies Pull requests that update a dependency file labels Feb 16, 2023
@danielhollas danielhollas marked this pull request as ready for review February 16, 2023 18:32
@unkcpz
Copy link
Member

unkcpz commented Feb 17, 2023

I create a new profile but the git and mamba completion still not working. Is any extra setting needed? For the verdi command, the autocompletion works. Since we add the configuration at

echo 'eval "$(_VERDI_COMPLETE=bash_source verdi)"' >> "${CONDA_DIR}/etc/conda/activate.d/activate_aiida_autocompletion.sh" && \

@danielhollas
Copy link
Contributor Author

danielhollas commented Feb 17, 2023 via email

@unkcpz
Copy link
Member

unkcpz commented Feb 17, 2023

Ah, sorry I download the image but forget to use it in the profile.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time I did the correct test. All good! Thanks!

@danielhollas danielhollas merged commit 3bd1ef2 into main Feb 23, 2023
@danielhollas danielhollas deleted the bash-completion branch February 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bash completion does not work for git, conda and other commands
2 participants