Move ssh agent start script to home prepare script

[unkcpz]

fixes #357

The sshagent source command is added everytime where the notebook start. I move the append to bashrc command to the script which create the bashrc and only attach the command the first time bashrc created.

[unkcpz]

Tested with aiidalab-launch locally and the .bashrc file looks all good.

[danielhollas]

@unkcpz I've tested this locally and this approach does not seem to work. Because in this case the .bashrc file already exists, it will never get appended.

Have you tested with a brand new environment (e.g. by running aiidalab-launch reset)

[unkcpz]

Have you tested with a brand new environment (e.g. by running aiidalab-launch reset)

I test by creating a new profile.

Because in this case the .bashrc file already exists,

I think this is the expected behavior, no? The .bashrc is created only the first time.

[unkcpz]

If you look at the earliest implement which the append is in the dockerfile

aiidalab-docker-stack/stack/base/Dockerfile

Lines 48 to 53 in 24787bf

	RUN wget --quiet --directory-prefix=/opt/bin/ \
	"https://aiida.readthedocs.io/projects/aiida-core/en/v${AIIDA_VERSION}/_downloads/4265ec5a42c3a3dba586dd460c0db95e/load-singlesshagent.sh" \
	&& echo $'\n# Load singlesshagent on shell startup.\n\
	if [ -f /opt/bin/load-singlesshagent.sh ]; then\n\
	. /opt/bin/load-singlesshagent.sh\n\
	fi\n' >> "/home/${NB_USER}/.bashrc"

. It has the problem that if the .bashrc exist in persistent volume, when the container instance is restarted (The current issue is when notebook restart), it will duplicate append the command.

[danielhollas]

For me the bashrc is always there, even on the first startup so in the current implementation it never get appended.

Are you using bind mount or volume mount?

[unkcpz]

The same problem of my test as #359, I forget to update the image in the profile. I'll check it again.

[unkcpz]

I remember there is a discrepancy between the docker and deployment by using jupyterhub. The .bashrc is created if run using aiidalab-launch by docker. It needs a clever way to append the text.

[danielhollas]

I would use a variable here

header="# Load singlesshagent on shell startup."

Otherwise looks okay, LMK when you want me to test this again @unkcpz

[unkcpz]

Yes, done!

[danielhollas]

LGTM! 🚀 I tested locally and it works.