Refactor installation routines and allow to run them from the CLI. #251
Conversation
|
Depends on aiidalab/aiidalab#295 . |
There was a problem hiding this comment.
@csadorf thanks! The codes all look good. Just a minor request.
Since this change depend on the aiidalab, I think we need to also add aiidalab dependency in the setup.cfg file?
I still need to test this PR thoroughly both with CLI and install qe from setup widget. (Tested and all good from my side.)
| @@ -281,6 +277,10 @@ def _update(self, change): | |||
|
|
|||
| if self.error or self.installed: | |||
| self._progress_bar.value = 1.0 | |||
| elif self.busy: | |||
| self._progress_bar.value = ProgressBar.AnimationRate(1.0) | |||
There was a problem hiding this comment.
What is the rate equal to 1.0 means? Can you add a comment in the code?
There was a problem hiding this comment.
Sure, would that be sufficient?
| self._progress_bar.value = ProgressBar.AnimationRate(1.0) | |
| # Start progress bar animation at constant rate (1.0). | |
| self._progress_bar.value = ProgressBar.AnimationRate(1.0) |
There was a problem hiding this comment.
Hmm, I still don't get the intuitive idea of what the 1.0 mean and in what unit?
| for code_name in CODE_NAMES: | ||
| if not _code_is_setup(code_name): | ||
| yield f"Setting up AiiDA code ({code_name})..." | ||
| _setup_code(code_name) |
There was a problem hiding this comment.
After installing and setup of the code finished successfully, the FN_DO_NOT_SETUP need to be removed? Or it is already somewhere else?
There was a problem hiding this comment.
The FN_DO_NOT_SETUP file prevents the installation. It is only created if the setup failed. That is to prevent the setup to make an attempt to perform the installation every time the app is opened.
There was a problem hiding this comment.
I see, probably I set up code by hand long ago, I both have code successfully set up and FN_DO_NOT_SETUP file. I test with remove this file and creating a new profile to test and all works fine.
It does not, what made you think that? |
Because the |
Yes, but the installation is still triggered like before if post_install is ignored. But we could also require a higher aiidalab version if you prefer that. |
csadorf
deleted the
feature/249-trigger-installation-of-qe-and-pseudo-installation-after-app-installation
branch
) After PR #251 there is an issue that `SSSPInstallWidget` can not update the state to installed even if the pseudo libraries are properly installed. The reason is that SSSPInstallWidget once updates the installed traitlets in `_refresh_installed` but not in the new implementation. The way to fix this is to set the `installed` state if function `install()` finished okay.
No description provided.