[pre-commit.ci] pre-commit autoupdate #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0) - [github.com/PyCQA/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0) - [github.com/kynan/nbstripout: 0.5.0 → 0.6.1](kynan/nbstripout@0.5.0...0.6.1)
|
Superseded by #331 |
unkcpz
pushed a commit
that referenced
this pull request
Dec 12, 2022
Put back uploading screenshots as artifacts. Screenshots were previously generated in the `screenshots/` directory inside the Git repo. However, we now change ownership of the Git repo that is mounted into the testing container to user jovyan. Therefore, the Git repo directory is no longer writable from outside the container, which means pytest cannot write to it and screenshot files are not saved. It is workaround by giving the package folder the write access of all user inside the container. Other fixes: 1. Do not test with multiple Python versions, tests themselves run inside the container so this was meaningles. 2. Fix the `setup.cfg`. See comment below. I needed to remove the `setupcfg-fmt` pre-commit hook, but since we plan to move to `pyproject.toml` anyway I think this is fine. 3. Version bumps of various testing dependencies. 4. Updated `pre-commit` plugins by running `pre-commit autoupdate` manually. This PR supersecedes #323
|
Closed by #331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: