Bump aiidalab-widgets-base to 2.0.0 beta #332
Conversation
| @@ -26,7 +26,7 @@ install_requires = | |||
| aiida-core~=2.1 | |||
There was a problem hiding this comment.
| aiida-core~=2.1 | |
| aiida-core>=2.1,<3 |
This should be quite safe I think. Otherwise you'll need to update this each time we update aiida-core in the Docker image.
There was a problem hiding this comment.
It is safe, but I think ~=2.1 will install 2.2 if it is released and the same as what you proposed the aiida-core>=2.1,<3, no?
There was a problem hiding this comment.
I am never sure about this, but I think in this case you need to use the carot, not tilde.
| aiida-core~=2.1 | |
| aiida-core^=2.1 |
There was a problem hiding this comment.
But the link you share is for npm package, for python we have PEP440 and please check https://peps.python.org/pep-0440/#compatible-release.
Also https://peps.python.org/pep-0440/#examples the examples.
There was a problem hiding this comment.
I think that aiida-core~=2.1 is equivalent to aiida-core>=2.1,<3.
It is safe, but I think
~=2.1will install2.2if it is released and the same as what you proposed theaiida-core>=2.1,<3, no?
Yes, but only if aiida is not yet installed. It will NOT force-update the current aiida version if it is between 2.1 and 3.0
There was a problem hiding this comment.
Why are we discussing this, by the way? The PR is about AWB, I guess :)
There was a problem hiding this comment.
But the link you share is for npm package, for python we have PEP440 and please check https://peps.python.org/pep-0440/#compatible-release.
Also https://peps.python.org/pep-0440/#examples the examples.
Oh, that's a very good point. Now I understand the source of my confusion, I didn't realize there's a difference. Thanks!
|
thanks a lot @both. |
|
Hehe, @both is actually a person. |
No description provided.