Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict pydantic to fix testing #416

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Restrict pydantic to fix testing #416

merged 1 commit into from
Jun 20, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jun 19, 2023

The dependency is pinned by aiida-quantumespresso==4.4.0, which not release yet. Revert after the aiida-quantumespresso bump.

The dependency is pinned by `aiida-quantumespresso==4.4.0`, which not release yet. Revert after the aiida-quantumespresso bump.
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (827bb83) 52.13% compared to head (b7825e1) 52.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   52.13%   52.13%           
=======================================
  Files          16       16           
  Lines        1849     1849           
=======================================
  Hits          964      964           
  Misses        885      885           
Flag Coverage Δ
python-3.10 52.13% <ø> (ø)
python-3.8 52.19% <ø> (?)
python-3.9 52.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@unkcpz unkcpz requested a review from superstar54 June 19, 2023 22:03
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@unkcpz unkcpz merged commit 2c90f9a into main Jun 20, 2023
@unkcpz unkcpz deleted the restrict-pydantic branch June 20, 2023 08:25
unkcpz added a commit that referenced this pull request Jan 11, 2024
The pydantic is pinned in #416, after the release of `aiida-quantumespresso` it is not needed, this PR bump the aiida-quantumespresso and unpin the pydantic.
unkcpz added a commit that referenced this pull request Jan 16, 2024
The pydantic is pinned in #416, after the release of `aiida-quantumespresso` it is not needed, this PR bump the aiida-quantumespresso and unpin the pydantic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants