Detects the unsaved changes in the already confirmed steps. #537
Conversation
additional modifications: - changing visibility with display, for the codes. In this way, no extra blank space is allocated if a code is not visible. using the visibility attribute for the layout allocates it even if the code is hidden
…nput_structure. This is needed to allow a dynamic display of the codes in step 3, if something is changed in step 2.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 79.07% 79.36% +0.28%
==========================================
Files 47 47
Lines 3211 3251 +40
==========================================
+ Hits 2539 2580 +41
+ Misses 672 671 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Adding dynamic visualization of codes
|
After a discussion with @unkcpz , we decided to make the following changes:
We also agreed that in the submit step, updating the blocker_message inside the @unkcpz Please have another check. |
| if change["new"]: | ||
| fmt_list = "\n".join((f"<li>{item}</li>" for item in sorted(change["new"]))) | ||
| """Observe the submission blockers and update the message area.""" | ||
| blockers = self.internal_submission_blockers + self.external_submission_blockers |
There was a problem hiding this comment.
- Is that possible that blockers are
Nonethen you cannot use+. - The
changeis not used, please use_in as argment.
There was a problem hiding this comment.
Thanks for the suggestion. I change it to _change. The blockers are always list, I think we don't need to check None here.
There was a problem hiding this comment.
If the variable is not used usually we use _ in widget callback.
There was a problem hiding this comment.
Thanks @superstar54, some more requests. Should be all fine then, I'll give it a through test then.
|
@unkcpz Thanks for your review. I made the changes as you suggested. Please test it. |
src/aiidalab_qe/app/main.py
Outdated
|
|
||
| def _observe_selected_index(self, change): | ||
| """Check unsaved change in the step when leaving the step.""" | ||
| with self.submit_step.hold_sync(): |
There was a problem hiding this comment.
I think this is not needed, only at very end the submit_step is updated.
In #537 we introduce a mechanism that when the structure setup step or configure setup step is modified without confirmation, the submission step will be blocked. When loading finished calculations from the workflow selection bar, since setup steps are not confirmed, the user has to go back to previous steps to confirm which is not ideal. This PR make it automatically confirm the setup steps when the workflows are loaded from workflow selection dropdown.
In the discussion with @unkcpz and @mikibonacci , we proposed a solution to handle the situation where the user edits the already confirmed steps.
This PR detects the unsaved changes in the already confirmed steps. If there are any unsaved changes, it will block the submit step and show the blocker messages there.
The technique details:
selected_indexof the_wizard_app_widget, and comparing the related values (confirmed_structurein the step1, andconfiguration_parametersin step 2)._submission_blockersis added in the app and linked to the_app_submission_blockersin the submit step.