Remove unused leftover files #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #490 The relevant changes needed are: pinging the aiida-pseudo version. Refactoring the methods in setup_pseudos.py to support flexible parameter passing. Note that from the test all 8 pseudos seems to only save ~10s but in the place where the network condition is bad, this is very helpful. --------- Co-authored-by: superstar54 <xingwang1991@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 80.73% 80.73%
=======================================
Files 49 49
Lines 3415 3415
=======================================
Hits 2757 2757
Misses 658 658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Ah, sorry, it was caused by I forced commit to update the commit message yesterday. Should be fine now. |
yakutovicha
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess these files were not used for quite a while, some are needed to run it through the binder, but we don't have a plan to support it anymore I assume? Pining @yakutovicha for comment, you are the only one who has a picture of the history of the app from its birth.