Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set structure traitlet to None before assigning new structure #549

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danielhollas
Copy link
Contributor

Cherry-picked from #383 by @cpignedoli

Fixes #381

This fixes the setting of self.structure = None when a action button is pressed for an importer ("SMILES" and "import from computer")

Thanks, @danielhollas, I tried self.structure = None just in observe("input_structure") but this does not work still, I keep the modification also in that observe.

TODO(DH): Need to test this

@danielhollas danielhollas marked this pull request as draft April 10, 2024 02:31
@danielhollas danielhollas added this to the v0.2.3 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure importers: cannot import the same structure twice.
2 participants