Check forked process calls for success during app installation. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadorf
force-pushed
the
fix/install-process
branch
from
e706266
to
e2738d2
Compare
|
@yakutovicha After this is merged we can make one final release that supports aiida-core 1.x, and then with the next release we only support AiiDA 2.x. |
yakutovicha
approved these changes
Jul 28, 2022
|
@yakutovicha Do you want me to create the release? |
yes, please go ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the exit code of forked subprocess to ensure that issues actually propagate up
and that the installation process does not simply proceed despite errors, e.g., during
the installation of dependencies.