available versions list unified by consider prereleases and core compatible in same function

[unkcpz]

fixes #360

The available_versions of _AiidalabApp data class object not considered core compatible. The core compatible check is implement independently and sporadically when the available_versions list is required.
This commit add the core compatible check inside the function available_versions of _AiidalabApp class to get the only usable versions for both when prereleases option is on and off. Therefore the version list conforms with what is shown in the version_to_install dropdown option.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@6acf490). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage        ?   59.36%           
=======================================
  Files           ?       12           
  Lines           ?     1110           
  Branches        ?        0           
=======================================
  Hits            ?      659           
  Misses          ?      451           
  Partials        ?        0           

Flag	Coverage Δ
py-3.10	59.36% <0.00%> (?)
py-3.8	59.36% <0.00%> (?)
py-3.9	59.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[unkcpz]

I test this in the old stack, all good for me. The update button is not wrongly activated anymore.

[danielhollas]

@unkcpz thanks so much for fixing this and adding a test. I also tested both in the new and old Docker stack.

My only request, while we are here, could you please add a bunch more tests for testing different scenarios for the AppRemoteUpdateStatus:

1. App is not registered. The AppRemoteUpdateStatus should be set accordingly.
2. App has a compatible update.
3. App is at the latest version.

[unkcpz]

• App is not registered. The AppRemoteUpdateStatus should be set accordingly.
• App has a compatible update.
• App is at the latest version.

The first is covered by test_app_is_not_registered and test_update_status_of_unregistred_app, 2 and 3 are covered by test_update_status_latest_version_incompatible already.

[danielhollas]

@unkcpz thanks! I will review and test again this evening.

[danielhollas]

@unkcpz just a one ask to change the app path in the fixture.

test_update_status_of_unregistred_app, 2 and 3 are covered by test_update_status_latest_version_incompatible already.

I don't see the case where an app is installed and has a valid update available so that its status is AppRemoteUpdateStatus.UPDATE_AVAILABLE. I guess just adding an assert for this to some existing test would suffice?

[danielhollas]

Cheers!