Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing get_aiida_class in some model classes #202

Closed
aiida-bot opened this issue May 12, 2016 · 1 comment
Closed

Missing get_aiida_class in some model classes #202

aiida-bot opened this issue May 12, 2016 · 1 comment
Assignees
@szoupanos
Labels
priority/important topic/database-schema topic/database-sqlalchemy type/task
Milestone
v1.0.0b1

Comments

@aiida-bot
Copy link

Originally reported by: Leonid Kahle (Bitbucket: leonidkahle, GitHub: lekah)

All classes in the models that are represented in the Aiida-ORM should have a method get_aiida_class, similar to DbComputer, DbWorkflow, DbNode. This would provide a consistent way to get the the Aiida-ORM instance after a query.

That function is missing in DbGroup (SQLA), and maybe others.
@szoupanos szoupanos added this to the Pre-1.0 release milestone Mar 1, 2017
@sphuber sphuber removed this from the pre-1.0 release milestone May 9, 2018
@sphuber sphuber added this to the v1.0.0 milestone Dec 3, 2018
@sphuber sphuber modified the milestones: v1.0.0, v1.0.0b1 Dec 4, 2018
@lekah lekah removed their assignment Dec 7, 2018
@sphuber
Copy link
Contributor

sphuber commented Dec 8, 2018

The get_aiida_class concept has been removed and replaced in PR #2309

@sphuber sphuber closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szoupanos szoupanos

Labels
priority/important topic/database-schema topic/database-sqlalchemy type/task
Projects
None yet
Milestone
v1.0.0b1
Development

No branches or pull requests
5 participants
@sphuber @lekah @giovannipizzi @szoupanos @aiida-bot