remove useless chainmap dependency #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems the dependency was introduced together with the caching mechanism but ended up not being used at all. Will remove the dependency in 1.0.0 as well.
|
Just want to point out that the same travis test passes on my fork: |
…_core into remove-chainmap-dependency
|
@waychal after merging this & updating your REST API, the docs build should, hopefully, pass |
sphuber
approved these changes
Apr 29, 2019
ltalirz
added a commit
to ltalirz/aiida-core
that referenced
this pull request
Jun 5, 2019
it seems that, for whatever reason, the issue described here has resurfaced: aiidateam#2420 (comment) It was thought that this could be prevented by adding the `--no-cache-dir` argument to pip here: aiidateam#2799 but apparently this fix was fortuituous?
ltalirz
added a commit
that referenced
this pull request
Jun 21, 2019
* docs: add note on increasing work_mem + restructure troubleshooting section a bit + incorporate suggestions by @kjappelbaum + add a vacuum Note on failing travis build it seems that, for whatever reason, the issue described here has resurfaced: #2420 (comment) It was thought that this could be prevented by adding the `--no-cache-dir` argument to pip here: #2799 but apparently this fix was fortuitous...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems the dependency was introduced together with the caching
mechanism but ended up not being used at all.
Will remove the dependency in 1.0.0 as well.
Note: this is breaking the conda build - the dependency is currently not installed (because it is not available on conda-forge) and so you get an import error when doing
verdi quicksetup.