Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note on increasing work_mem #2952

Merged
merged 5 commits into from
Jun 21, 2019

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented May 31, 2019

fix #2859

  • add note on increasing work_mem
  • restructure troubleshooting section a bit

@ltalirz ltalirz requested a review from kjappelbaum May 31, 2019 20:20
Copy link
Contributor

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the circus references, I would maybe add a hint that can be useful for debugging. If one sets log_temp_files = 0 in /etc/postgresql/10/main/postgresql.confone can check if the writing of temporary files is indeed an issue. Also I would probably recommend querying for the message table size and then adjusting thework_mem` setting based on that as e.g. for me and Daniele the table size was different.

 + restructure troubleshooting section a bit
@ltalirz
Copy link
Member Author

ltalirz commented Jun 1, 2019

thanks for the suggestions - I've tried to incorporate them
in order not to overcomplicate things I don't include instructions for tuning the value depending on the size of the table but I think it contains everything needed to get started debugging

Copy link
Contributor

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Leo!

kjappelbaum
kjappelbaum previously approved these changes Jun 2, 2019
it seems that, for whatever reason, the issue described here has resurfaced:
aiidateam#2420 (comment)

It was thought that this could be prevented by adding the
`--no-cache-dir` argument to pip here:
aiidateam#2799

but apparently this fix was fortuituous?
@ltalirz
Copy link
Member Author

ltalirz commented Jun 15, 2019

@sphuber do you have any idea why the tests failed? Seems to be exactly the same error as in #2420

It was thought that this could be prevented by adding the
--no-cache-dir argument to pip here: #2799
but perhaps that was fortuitous?

I also tried resetting the travis cache...

@sphuber
Copy link
Contributor

sphuber commented Jun 17, 2019

It does seem to be the same error, and indeed the --no-cache-dir did consistently fix the problem last time. Maybe now there is an incompatibility even when installing everything from scratch, i.e. the version of pymatgen that we tell to install, will automatically install a version of numpy and scipy that are incompatible.

@ltalirz
Copy link
Member Author

ltalirz commented Jun 21, 2019

I'm going to merge this now... will hopefully fix this travis problem at some point as well.

@ltalirz ltalirz merged commit 428aa52 into aiidateam:release_v0.12.4 Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants