Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憣 IMPROVE: virtualenv/virtualenvwrapper integration #4

Open
mbercx opened this issue May 7, 2023 · 2 comments
Open

馃憣 IMPROVE: virtualenv/virtualenvwrapper integration #4

mbercx opened this issue May 7, 2023 · 2 comments

Comments

@mbercx
Copy link
Member

mbercx commented May 7, 2023

The current approach still has some gaps in it (i.e. it doesn't install virtualenv by default), and in practise I still rely on the workon command of virtualenvwrapper without explicitly installing it. We should work on making this as seamless as possible in all possible machine setups.

@mbercx
Copy link
Member Author

mbercx commented May 23, 2023

Actually, perhaps we shouldn't use virtualenv at all, and simply use the venv module which is part of the standard library since Python 3.3. I don't immediately see an advantage of using virtualenv vs venv (also see this thread), and perhaps integration with virtualenvwrapper is also unnecessary.

@mbercx
Copy link
Member Author

mbercx commented Jun 8, 2023

Partially fixed in bf7b619.

Using the standard library package venv is definitely preferable, and the package will still look to see if WORKON_HOME has been set (which is the case for users of virtualenvwrapper). However, we should perhaps still add instructions for users that want to integrate virtualenvwrapper after starting to use aiida-project, i.e. point them to the correct WORKON_HOME setting to integrate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant