Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with aiida-core 2.5 #70

Open
qiaojunfeng opened this issue May 30, 2024 · 4 comments
Open

Compatibility with aiida-core 2.5 #70

qiaojunfeng opened this issue May 30, 2024 · 4 comments
Assignees

Comments

@qiaojunfeng
Copy link

It seems like there are some dependency conflicts with recent version of aiida-core, e.g. pydantic

'pydantic~=1.10',

for aiida-core v2.5.1
https://github.com/aiidateam/aiida-core/blob/v2.5.1/pyproject.toml#L42

Are there any plans to update this package? Thanks!

@ltalirz
Copy link
Member

ltalirz commented May 30, 2024

looks like @agoscinski last worked on it

@eimrek
Copy link
Member

eimrek commented May 31, 2024

thanks for making this issue. yes, the plan is to make this the official aiida REST API and deprecate the one built into aiida-core. Making it compatible with latest aiida-core is very important. @agoscinski indeed has been contributing to this repo and this could be a valuable next addition, if he has time.

@agoscinski agoscinski self-assigned this Jun 5, 2024
@agoscinski
Copy link
Collaborator

Haven't looked to it more than trying to run it. There were some pydantic errors when I updated that is why the pydantic version is pinned. Not sure yet how hard to solve this is. Will look into this more later.

@qiaojunfeng
Copy link
Author

Thank you all for the replies!

There were some pydantic errors when I updated that is why the pydantic version is pinned. Not sure yet how hard to solve this is. Will look into this more later.

Yes I tried the same, and to me it's not straightforward to solve the pydantic stuff.
Would be very useful if the restapi can be revived some time later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants