Remove the async function from aiida.work.run #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async function relied on the ParallelEngine of plum to launch multiple processes in parallel, however, during testing we discovered that the orm is not thread safe and race conditions could lead to unexpected behavior. The future version of plum that is currently in development for the renewed workflow engine will not support this for this reason. Therefore we remove this function here altogether in preparation for the improved workchain engine.
sphuber
force-pushed
the
fix_946_remove_async
branch
from
aea0ebc
to
40a9eab
Compare
giovannipizzi
requested changes
Jan 15, 2018
aiida/work/run.py
Outdated
|
|
||
| # return process_class(*args, **inputs), | ||
| # else: | ||
| # return process_class(*args, **inputs) |
giovannipizzi
approved these changes
Jan 15, 2018
|
@muhrin please check if you are okay with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946
The async function relied on the ParallelEngine of plum to
launch multiple processes in parallel, however, during testing
we discovered that the orm is not thread safe and race conditions
could lead to unexpected behavior. The future version of plum
that is currently in development for the renewed workflow engine
will not support this for this reason. Therefore we remove this
function here altogether in preparation for the improved workchain
engine.