-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AiiDA REST API #878
Conversation
Conflicts: aiida/restapi/translator/base.py
will move to separate fork in the future
Merge waychal/materialscloud into aiidateam/materialscloud
Merge waychal/Materialscloud into aiidateam/materialscloud
…ture_endpoint_mcloud
…_endpoints_mcloud
…r_endpoints_mcloud Fixed issue 793 restapi server endpoints
…ub.com/waychal/aiida_core into issue_777_restapi_user_endpoint_mcloud
…endpoint_mcloud Fixed issue 777 restapi user endpoint
…//github.com/waychal/aiida_core into issues_805_restapi_structure_endpoint_mcloud
…cture_endpoint_mcloud Fixed Issue 805 restapi structure endpoint
…restapi_structure_endpoint_mcloud
…ture_endpoint_mcloud
…restapi_structure_endpoint_mcloud
…cture_endpoint_mcloud Fixed issue aiidateam#872
Thanks for approving @giovannipizzi , but this was perhaps a bit fast ( @waychal still wanted to have a look).
|
Wow, a segmentation fault? Never seen one with python... Do you manage to understand which call is the cause? Is there a test for this format? (BTW, is this a small or a very big structure?) |
I just tried on my Mac and I don't get errors... probably it's a bug in the version of PyCifRW we use (btw, very old), and maybe happening for big structures? @nmounet and @merkys have been discussing upgrading pycifrw to a more recent version a few days ago, with the issue that PyCifRW changes API every new version... @nmounet, @merkys did you decide which version to upgrade to? BTW, @waychal : I just realised that you check if the output string you get for the CIF file is exactly the same (https://github.com/aiidateam/aiida_core/blob/0e0a7c55a7db70d644b47930ed7137a8cd3cc84e/aiida/backends/tests/restapi.py#L766) However, as PyCifRW often slightly changes the format of the output (e.g. more spaces, more comments, ...) between one version and another, it would be better to just check if the file is valid even if slightly different. E.g., if there are specific substrings like |
This discussion will continue in #882 |
@giovannipizzi: I could replace pycifrw with pycodcif (see my post in #882), however, I need a help to C-compile it on Mac. Also, this would require a migration of |
This adds a few fixes to the AiiDA REST API