Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shared_ptr to mange lifetime #3

Closed
ailrk opened this issue Mar 21, 2021 · 0 comments
Closed

use shared_ptr to mange lifetime #3

ailrk opened this issue Mar 21, 2021 · 0 comments
Assignees

Comments

@ailrk
Copy link
Owner

ailrk commented Mar 21, 2021

Parsers can have dependencies with each other, and we can't guarantee a parser always lives longer than those who depend on it. The current solution is simply copying the parser all the time. The plan is to use shared_ptr.

shared_ptr always has less overhead than std::functional when there is closure.

@ailrk ailrk self-assigned this Mar 21, 2021
@ailrk ailrk closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant