Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand devtools::check() warning notes #73

Closed
RayStick opened this issue Mar 6, 2024 · 2 comments
Closed

Understand devtools::check() warning notes #73

RayStick opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@RayStick
Copy link
Member

RayStick commented Mar 6, 2024

domain_mapping: no visible binding for global variable ‘Note’
  Undefined global functions or variables:
    Note

When @BatoolMM added at the top:

utils::globalVariables(c("Note"))

the warning stopped

@RayStick RayStick added the question Further information is requested label Mar 6, 2024
@RayStick RayStick changed the title warning about global variable Understand warning about global variable Mar 6, 2024
@RayStick RayStick added this to the Before 0.2.0 release milestone Mar 6, 2024
@RayStick RayStick removed this from the Before 0.2.0 release milestone Apr 3, 2024
@RayStick RayStick mentioned this issue Apr 9, 2024
1 task
@RayStick RayStick added the help wanted Extra attention is needed label Apr 10, 2024
@RayStick
Copy link
Member Author

RayStick commented Apr 10, 2024

Running devtools::check() on latest release (1.0.0) gives:

❯ checking for hidden files and directories ... NOTE
Found the following hidden files and directories:
.all-contributorsrc
These were most likely included in error. See section ‘Package
structure’ in the ‘Writing R Extensions’ manual.

❯ checking DESCRIPTION meta-information ... NOTE
Malformed Description field: should contain one or more complete sentences.

❯ checking top-level files ... NOTE
Non-standard files/directories found at top level:
‘CITATION.cff’ ‘CONTRIBUTING.md’ ‘data-raw’

❯ checking package subdirectories ... NOTE
Found the following CITATION file in a non-standard place:
CITATION.cff
Most likely ‘inst/CITATION’ should be used instead.

❯ checking R code for possible problems ... NOTE
compare_csv_outputs: no visible binding for global variable
‘MetaDataVersion’
compare_csv_outputs: no visible binding for global variable
‘MetaDataLastUpdated’
compare_csv_outputs: no visible binding for global variable
‘DomainListDesc’
compare_csv_outputs: no visible binding for global variable ‘Dataset’
compare_csv_outputs: no visible binding for global variable ‘Table’
compare_csv_outputs: no visible binding for global variable
‘DataElement’
domain_mapping: no visible binding for global variable ‘Note’
Undefined global functions or variables:
DataElement Dataset DomainListDesc MetaDataLastUpdated
MetaDataVersion Note Table

It would be good to understand these better, as it seems I may be declaring/handling variables in R in a sub-optimal way

@RayStick RayStick changed the title Understand warning about global variable Understand devtools::check() warning notes Apr 10, 2024
@RayStick
Copy link
Member Author

RayStick commented Jul 8, 2024

as this is not an error or a warning (just a note) I am going to close this for now

@RayStick RayStick closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants