You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The close message can be non-violently to return exit-statuses and acknowledgement of commands.
" When the command running at the other end terminates, the following
message can be sent to return the exit status of the command.
Returning the status is RECOMMENDED. No acknowledgement is sent for
this message. The channel needs to be closed with
SSH_MSG_CHANNEL_CLOSE after this message.
The remote command may also terminate violently due to a signal.
Such a condition can be indicated by the following message. A zero
'exit_status' usually means that the command terminated successfully.
"
Suggested fix is to allow for optional parameter in SendClose(uint? exitCode = null) in Channel.cs that dictates whether to "CheckBothClosed()" which will default to true to prevent any breaking change for other projects.
As per ssh documentation
The close message can be non-violently to return exit-statuses and acknowledgement of commands.
" When the command running at the other end terminates, the following
message can be sent to return the exit status of the command.
Returning the status is RECOMMENDED. No acknowledgement is sent for
this message. The channel needs to be closed with
SSH_MSG_CHANNEL_CLOSE after this message.
The client MAY ignore these messages.
The remote command may also terminate violently due to a signal.
Such a condition can be indicated by the following message. A zero
'exit_status' usually means that the command terminated successfully.
"
Suggested fix is to allow for optional parameter in SendClose(uint? exitCode = null) in Channel.cs that dictates whether to "CheckBothClosed()" which will default to true to prevent any breaking change for other projects.
I will submit a PR with the suggested fix.
The text was updated successfully, but these errors were encountered: