Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf version upper limit set to 4.0.0 #2455

Closed
hadim opened this issue Jan 3, 2023 · 5 comments
Closed

protobuf version upper limit set to 4.0.0 #2455

hadim opened this issue Jan 3, 2023 · 5 comments
Assignees
Labels
area / SDK-storage Issue area: SDK and storage related issues phase / shipped Issue phase: shipped type / code-health Issue type: suggest a code improvement, i.e. refactoring, deprecation, etc type / enhancement Issue type: new feature or request
Milestone

Comments

@hadim
Copy link

hadim commented Jan 3, 2023

🚀 Feature

The current version of allowed protobuf is set to <4.0.0 which makes it hard to use aim in a stack with a more updated protobuf version.

Would that be possible to remove that constraint?

@hadim hadim added the type / enhancement Issue type: new feature or request label Jan 3, 2023
@gorarakelyan gorarakelyan added the type / code-health Issue type: suggest a code improvement, i.e. refactoring, deprecation, etc label Jan 3, 2023
@gorarakelyan
Copy link
Contributor

gorarakelyan commented Jan 3, 2023

thanks @hadim, we will look into it.
@mihran113 @alberttorosyan tagging you, so you are aware of this thread.

@mihran113
Copy link
Contributor

There were some compatibility issues with protobuf v4 that's why we've limited the upper version, will look into it to see what's possible to do about that.

@hadim
Copy link
Author

hadim commented Jan 3, 2023

Thanks guys.

FYI: I am currently trying to build the latest version on conda-forge: conda-forge/aim-feedstock#14. It's a bit of work since it also requires a couple of other packages to be created or to update (see conda-forge/aim-feedstock#14 (comment)).

Being able to lower the number of upper bound version for important deps (protobuf and fastapi for example) would be really great to be able to integrate smoothly aim in any existing stack.

@mihran113
Copy link
Contributor

We'll remove the upper limits of fastapi with the v3.16.0 of aim, as we're planning to drop the support for python3.6, will work on this too. :)

@mihran113 mihran113 self-assigned this Jan 13, 2023
@mihran113 mihran113 added this to the v3.16.0 milestone Jan 13, 2023
@mihran113 mihran113 added area / SDK-storage Issue area: SDK and storage related issues phase / review-needed Issue phase: issues that are done and needs review phase / ready-to-go Issue phase: issues that are merged and will be included in the upcoming release and removed phase / review-needed Issue phase: issues that are done and needs review labels Jan 13, 2023
@mihran113 mihran113 added phase / shipped Issue phase: shipped and removed phase / ready-to-go Issue phase: issues that are merged and will be included in the upcoming release labels Feb 6, 2023
@mihran113
Copy link
Contributor

Hey @hadim! The protobuf's upper limits and also fastapi's as well has been dropped with the new 3.16.0 release.

@hadim hadim closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area / SDK-storage Issue area: SDK and storage related issues phase / shipped Issue phase: shipped type / code-health Issue type: suggest a code improvement, i.e. refactoring, deprecation, etc type / enhancement Issue type: new feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants