Skip to content
This repository has been archived by the owner on Nov 7, 2021. It is now read-only.

HTTP Basic Auth #27

Closed
roll opened this issue Aug 18, 2015 · 7 comments
Closed

HTTP Basic Auth #27

roll opened this issue Aug 18, 2015 · 7 comments

Comments

@roll
Copy link

roll commented Aug 18, 2015

It looks like there is no chance to use HTTP Basic Auth for now?
@roll roll changed the title Basic auth HTTP Basic Auth Aug 18, 2015
@asvetlov
Copy link
Contributor

No, but basic auth support can be added easy.
Would you like making a Pull Request?

@roll
Copy link
Author

roll commented Aug 19, 2015

Thanks. I'll make a shot. Monkeypathed Connection.perform_request works. It looks like I just have to provide http_auth string/tuple parameter thru Elasticearch and Transport classes.

@asvetlov
Copy link
Contributor

Yes, http_auth looks good. It should be aiohttp.BasicAuth parameter: https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/helpers.py#L14

@mpaolini
Copy link
Contributor

mpaolini commented Jun 9, 2016

implemented in #40

@mpaolini
Copy link
Contributor

I think we can close this one as done. See #40

@mpaolini
Copy link
Contributor

ping we can close this

@asvetlov
Copy link
Contributor

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvetlov @mpaolini @roll