Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up-to-date botocore #1057

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Nov 18, 2023

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains several minor changes that affect this codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): resolves Support botocore 1.32.1 with its massive decrease in package size #1056
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved: The required updates to args.py, client.py, and utils.py turned out to be trivial.
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (281e68d) 86.39% compared to head (7b70394) 86.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   86.39%   86.46%   +0.06%     
==========================================
  Files          60       60              
  Lines        5807     5814       +7     
==========================================
+ Hits         5017     5027      +10     
+ Misses        790      787       -3     
Flag Coverage Δ
unittests 86.46% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review November 18, 2023 22:24
@jakob-keller
Copy link
Collaborator Author

jakob-keller commented Nov 28, 2023

@thehesiod: This PR adds support for a whole bunch of new and updated AWS services that are released during re:Invent 2023. I suggest to do a release soon to maintain feature parity.

botocore>=1.33.2 includes many new codepaths and will likely be a major piece of work for us. This will need to be worked on in another PR.

@thehesiod
Copy link
Collaborator

that's so awesome you added link to diff. We need to add that to the template in the checklist with example

@thehesiod thehesiod merged commit ab08687 into aio-libs:master Nov 29, 2023
11 checks passed
@thehesiod
Copy link
Collaborator

looks great, thanks!

@@ -7,15 +7,15 @@
# NOTE: When updating botocore make sure to update awscli/boto3 versions below
install_requires = [
# pegged to also match items in `extras_require`
'botocore>=1.31.16,<1.31.71',
'botocore>=1.32.4,<1.33.2',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this in the review, it's doubtful this aiobotocore is compatible across these versions given it required changes to match the latest botocore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support botocore 1.32.1 with its massive decrease in package size
2 participants