-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to botocore 1.12.49 #639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 93.46% 93.89% +0.42%
==========================================
Files 9 9
Lines 551 557 +6
==========================================
+ Hits 515 523 +8
+ Misses 36 34 -2
Continue to review full report at Codecov.
|
^^ I decided to be more patient and not prod you but I clicked the wrong button 😃 |
@thehesiod - mind reviewing this 😄 |
Bump 😄 |
@thehesiod bumping this. @terrycain needs to be updated to 1.12.44 for moto compatibility. |
Updated PR so that it now uses botocore 1.12.49 |
Any update on this? |
I will take a look. |
thanks! |
New version released https://pypi.org/project/aiobotocore/0.10.0/ |
Wow, I have no idea why I didn't get notifications for this. Sorry! Had I seen this I would have looked into it. |
Thanks all! |
Oh I think this got lumped together with the dependencies update notifications, doh |
@terrycain sorry for noise about patches, everything was correct, trying to track down some strangeness with pyup-bot |
Botocore hasn't changed much between 1.10.58 to 1.12.24. The main ones are the changes to the event names emitted, and that botocore now use a urllib session class, so some arguments are no longer supported in the endpoint base class.
There's some weird travis bug at the moment (travis-ci/travis-ci#7940), added in
BOTO_CONFIG
env var to solve that until its fixed properly.