Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to botocore 1.12.49 #639

Merged
merged 5 commits into from
Dec 9, 2018
Merged

Update to botocore 1.12.49 #639

merged 5 commits into from
Dec 9, 2018

Conversation

terricain
Copy link
Collaborator

Botocore hasn't changed much between 1.10.58 to 1.12.24. The main ones are the changes to the event names emitted, and that botocore now use a urllib session class, so some arguments are no longer supported in the endpoint base class.

There's some weird travis bug at the moment (travis-ci/travis-ci#7940), added in BOTO_CONFIG env var to solve that until its fixed properly.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #639 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   93.46%   93.89%   +0.42%     
==========================================
  Files           9        9              
  Lines         551      557       +6     
==========================================
+ Hits          515      523       +8     
+ Misses         36       34       -2
Impacted Files Coverage Δ
aiobotocore/args.py 97.36% <ø> (ø) ⬆️
aiobotocore/client.py 95.06% <100%> (+0.12%) ⬆️
aiobotocore/endpoint.py 95.42% <100%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae08462...dc453cd. Read the comment docs.

@terricain
Copy link
Collaborator Author

@thehesiod

@terricain terricain closed this Oct 18, 2018
@terricain terricain reopened this Oct 18, 2018
@terricain
Copy link
Collaborator Author

^^ I decided to be more patient and not prod you but I clicked the wrong button 😃

@terricain
Copy link
Collaborator Author

@thehesiod - mind reviewing this 😄

@terricain
Copy link
Collaborator Author

Bump 😄

@e271828-
Copy link

e271828- commented Nov 14, 2018

@thehesiod bumping this. @terrycain needs to be updated to 1.12.44 for moto compatibility.

@terricain terricain changed the title Update to botocore 1.12.24 Update to botocore 1.12.49 Nov 21, 2018
@terricain
Copy link
Collaborator Author

Updated PR so that it now uses botocore 1.12.49

@terricain
Copy link
Collaborator Author

Any update on this?

@gricey432 gricey432 mentioned this pull request Dec 9, 2018
@jettify
Copy link
Member

jettify commented Dec 9, 2018

I will take a look.

@jettify jettify merged commit 0167c83 into aio-libs:master Dec 9, 2018
@jettify
Copy link
Member

jettify commented Dec 9, 2018

thanks!

@jettify
Copy link
Member

jettify commented Dec 9, 2018

New version released https://pypi.org/project/aiobotocore/0.10.0/

@thehesiod
Copy link
Collaborator

thehesiod commented Dec 10, 2018

Wow, I have no idea why I didn't get notifications for this. Sorry! Had I seen this I would have looked into it.

@thehesiod
Copy link
Collaborator

Thanks all!

@thehesiod
Copy link
Collaborator

Oh I think this got lumped together with the dependencies update notifications, doh

@thehesiod
Copy link
Collaborator

@terrycain sorry for noise about patches, everything was correct, trying to track down some strangeness with pyup-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants