Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 3.6 support #936

Merged
merged 14 commits into from
May 9, 2022
Merged

fix 3.6 support #936

merged 14 commits into from
May 9, 2022

Conversation

thehesiod
Copy link
Collaborator

@thehesiod thehesiod commented May 9, 2022

pipenv was "upgrading" the python version :( Tons of test related stuff was actually broken in 3.6. Next major release we should drop 3.6 support

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #936 (267072d) into master (d9e1438) will increase coverage by 0.13%.
The diff coverage is 92.68%.

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   86.64%   86.77%   +0.13%     
==========================================
  Files          52       55       +3     
  Lines        5272     5295      +23     
==========================================
+ Hits         4568     4595      +27     
+ Misses        704      700       -4     
Flag Coverage Δ
unittests 86.77% <92.68%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_eventstreams.py 100.00% <ø> (+35.00%) ⬆️
tests/python3.8/test_eventstreams.py 17.64% <17.64%> (ø)
tests/boto_tests/test_credentials.py 97.28% <93.33%> (ø)
tests/boto_tests/test_utils.py 95.23% <95.23%> (ø)
aiobotocore/_helpers.py 100.00% <100.00%> (ø)
aiobotocore/utils.py 76.02% <100.00%> (-0.29%) ⬇️
aiobotocore/waiter.py 90.56% <100.00%> (+0.18%) ⬆️
tests/boto_tests/helpers.py 85.71% <100.00%> (ø)
tests/boto_tests/test_signers.py 100.00% <100.00%> (ø)
tests/conftest.py 91.87% <100.00%> (+0.14%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e1438...267072d. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 9, 2022

This pull request introduces 2 alerts when merging f88d8eb into d9e1438 - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 9, 2022

This pull request introduces 2 alerts when merging c8a65ae into d9e1438 - view on LGTM.com

new alerts:

  • 2 for Unused import

@thehesiod
Copy link
Collaborator Author

ok biting the bullet and installing py3.6 ;)

@lgtm-com
Copy link

lgtm-com bot commented May 9, 2022

This pull request introduces 2 alerts when merging 0d1b6db into d9e1438 - view on LGTM.com

new alerts:

  • 2 for Unused import

@thehesiod thehesiod merged commit 4c18d3d into master May 9, 2022
@thehesiod thehesiod deleted the thehesiod/3.6 branch May 9, 2022 06:30
@lgtm-com
Copy link

lgtm-com bot commented May 9, 2022

This pull request introduces 2 alerts when merging 267072d into d9e1438 - view on LGTM.com

new alerts:

  • 2 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant