-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 3.6 support #936
fix 3.6 support #936
Conversation
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
+ Coverage 86.64% 86.77% +0.13%
==========================================
Files 52 55 +3
Lines 5272 5295 +23
==========================================
+ Hits 4568 4595 +27
+ Misses 704 700 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pull request introduces 2 alerts when merging f88d8eb into d9e1438 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging c8a65ae into d9e1438 - view on LGTM.com new alerts:
|
ok biting the bullet and installing py3.6 ;) |
This pull request introduces 2 alerts when merging 0d1b6db into d9e1438 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 267072d into d9e1438 - view on LGTM.com new alerts:
|
pipenv was "upgrading" the python version :( Tons of test related stuff was actually broken in 3.6. Next major release we should drop 3.6 support