Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Test files appearing in distribution package #937 #938

Merged
merged 2 commits into from
May 11, 2022
Merged

fix Test files appearing in distribution package #937 #938

merged 2 commits into from
May 11, 2022

Conversation

slobberchops
Copy link
Contributor

@slobberchops slobberchops commented May 9, 2022

Description of Change

Explicitly indicated aiobotocore package as intended target for installation.

Verified that tests directory does no appear in built distribution package.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

CHANGES.rst Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #938 (4f4a128) into master (4c18d3d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #938   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files          55       55           
  Lines        5295     5295           
=======================================
  Hits         4595     4595           
  Misses        700      700           
Flag Coverage Δ
unittests 86.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c18d3d...4f4a128. Read the comment docs.

@thehesiod thehesiod merged commit a5920f6 into aio-libs:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants