Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test files appearing in distribution package #937

Closed
1 of 6 tasks
slobberchops opened this issue May 9, 2022 · 1 comment
Closed
1 of 6 tasks

Test files appearing in distribution package #937

slobberchops opened this issue May 9, 2022 · 1 comment

Comments

@slobberchops
Copy link
Contributor

slobberchops commented May 9, 2022

Describe the bug
The tests directory has been copied into the 2.3.2 distribution package. These files do not exist when downloading the 2.3.1 package. The existence of the test directory is likely unintentional and appears as a module when installed into a virtual environment.

This problem can be reproduced by creating a virtual environment and installing aiobotocore.

python3.9 -m venv aiobotocore
./aiobotocore/bin/pip install aiobotocore==2.3.2
 ls ./aiobotocore/lib/python3.9/site-packages/tests
... __init__.py  conftest.py       test_basic_s3.py  test_ec2.py	       test_mturk.py	 test_sns.py
... __pycache__  mock_server.py    test_batch.py	 test_eventstreams.py  test_patches.py	 test_sqs.py
... _helpers.py  moto_server.py    test_config.py	 test_lambda.py        test_response.py  test_version.py
... boto_tests   test_adaptive.py  test_dynamodb.py  test_monitor.py       test_session.py	 test_waiter.py

Installing 2.3.1 does not install the tests directory.

I also downloaded both 2.3.2 and 2.3.1 packages and verified that 2.3.2 contains tests whereas 2.3.1 does not.

Checklist

  • I have reproduced in environment where pip check passes without errors
  • I have provided pip freeze results
  • I have provided sample code or detailed way to reproduce
  • I have tried the same code in botocore to ensure this is an aiobotocore specific issue
  • I have tried similar code in aiohttp to ensure this is is an aiobotocore specific issue
  • I have checked the latest and older versions of aiobotocore/aiohttp/python to see if this is a regression / injection

pip freeze results

Environment:

  • Python Version: 3.9
  • OS name and version: Darwin

Additional context
As an aside, installation of tests as a module appears to cause some confusion with IntelliJ which then has trouble when working on a project that also uses tests as its test directory.

brettlangdon added a commit to DataDog/dd-trace-py that referenced this issue May 12, 2022
`aiobotocore==2.3.2` included `tests` module in it's distribution
this causes conflicts with our `tests` module.

Pin until aio-libs/aiobotocore#937 is resolved
brettlangdon added a commit to DataDog/dd-trace-py that referenced this issue May 12, 2022
`aiobotocore==2.3.2` included `tests` module in it's distribution
this causes conflicts with our `tests` module.

Pin until aio-libs/aiobotocore#937 is resolved
mergify bot pushed a commit to DataDog/dd-trace-py that referenced this issue May 12, 2022
`aiobotocore==2.3.2` included `tests` module in it's distribution
this causes conflicts with our `tests` module.

Pin until aio-libs/aiobotocore#937 is resolved

(cherry picked from commit 5105e87)
mergify bot pushed a commit to DataDog/dd-trace-py that referenced this issue May 12, 2022
`aiobotocore==2.3.2` included `tests` module in it's distribution
this causes conflicts with our `tests` module.

Pin until aio-libs/aiobotocore#937 is resolved

(cherry picked from commit 5105e87)
@thehesiod
Copy link
Collaborator

looks like tests folder is now gone in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants