Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp_cors is not compatible with aiohttp 1.1 #49

Closed
asvetlov opened this issue Oct 13, 2016 · 3 comments
Closed

aiohttp_cors is not compatible with aiohttp 1.1 #49

asvetlov opened this issue Oct 13, 2016 · 3 comments
Assignees

Comments

@asvetlov
Copy link
Member

I'll manage it before publishing aiohttp 1.1

@asvetlov asvetlov self-assigned this Oct 13, 2016
@asvetlov
Copy link
Member Author

Hmm, how to test against aiohttp master locally?

pip install -e ../aiohttp  # points to local master
pytest tests

shows successful result.

@rutsky
Copy link
Member

rutsky commented Oct 31, 2016

@asvetlov can you post logs of pytest invocation?

I just tested following commands:

$ git clone git@github.com:aio-libs/aiohttp-cors.git
$ git clone https://github.com/KeepSafe/aiohttp.git
$ python3.5 -m venv env
$ source env/bin/activate
$ pip install -e aiohttp
$ cd aiohttp-cors
$ pip install -r requirements-dev.txt
$ pytest tests

and pytest tests fails there.

@asvetlov
Copy link
Member Author

asvetlov commented Nov 1, 2016

Sorry, it was a problem with my local virtual environment

@asvetlov asvetlov closed this as completed Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants